Skip to content

Commit

Permalink
alarms: fix regex for checksum alarm
Browse files Browse the repository at this point in the history
The alarm definition for CHECKSUM uses the regex

Marking (.+) as BROKEN.

Unfortunately this matches both the error emitted by
the ChecksumScanner

 _log.error("Marking {} as BROKEN: {}", id, e.getMessage());

as well as the broken file message from WriteHandleImpl:

 _log.warn("Marking pool entry as BROKEN");

The latter should not produce an alarm.

The regex for the CHECKSUM alarm has been made more specific
in order to exclude matching the latter logging statement.

Note that the changes to alarms in 2.11 render this
patch unnecessary for 2.11 or master.

Target: 2.10
Request: 2.9
Request: 2.8
Reqeust: 2.7
Reqeust: 2.6
Acked-by: Dmitry
Require-notes: no
Require-book: no
  • Loading branch information
alrossi committed Nov 10, 2014
1 parent 0fa1e1c commit 0dee828
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions skel/var/alarms/alarm-definitions.xml
Expand Up @@ -94,9 +94,9 @@
<alarmType>
<logger>org.dcache.pool.classic.ChecksumScanner</logger>
<type>CHECKSUM</type>
<regex>Marking (.+) as BROKEN</regex>
<regex>Marking ([0-9A-F]+{24}) as BROKEN</regex>
<level>ERROR</level>
<severity>MODERATE</severity>
<severity>HIGH</severity>
<includeInKey>group1 type host service domain</includeInKey>
</alarmType>
</definitions>

0 comments on commit 0dee828

Please sign in to comment.