Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEFAULT_CONFIG_DIRECTORY in code is different from doc #7

Closed
MorphBonehunter opened this issue Jan 27, 2022 · 1 comment
Closed

DEFAULT_CONFIG_DIRECTORY in code is different from doc #7

MorphBonehunter opened this issue Jan 27, 2022 · 1 comment

Comments

@MorphBonehunter
Copy link

In the Readme it is documented that the user provided config should/could be placed in

  • C:/Users/{username}/.yasb/config.yaml

As this doesn't work for me, the config didn't load and the log doesn't give me an hint i look at the code.

In the config_utils.py it is mentioned that the home dir is constructed from Path.home() and DEFAULT_CONFIG_DIRECTORY
but the DEFAULT_CONFIG_DIRECTORY in settings.py is actually set to .yabar.

So there are 2 possibilities in my eyes:

  1. change docs to mention that C:/Users/{username}/.yabar/config.yaml should be used
  2. update DEFAULT_CONFIG_DIRECTORY to .yasb

I would prefer option 2 as this fits more but that's just my 2ct ;)

@da-rth
Copy link
Owner

da-rth commented Jan 29, 2022

@MorphBonehunter thanks for spotting this, I had previously named yasb as yabar back in early development and clearly forgot to change the default config directory,

The DEFAULT_CONFIG_DIRECTORY has now been changed to .yasb

Please refer to commit ab4d3a6 for more information

@da-rth da-rth closed this as completed Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants