Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename gem? #10

Open
key88sf opened this issue Feb 5, 2014 · 7 comments
Open

Rename gem? #10

key88sf opened this issue Feb 5, 2014 · 7 comments

Comments

@key88sf
Copy link

key88sf commented Feb 5, 2014

There is already a geoip2 gem which is built for the Maxmind GeoIP2 webservice (https://github.com/YotpoLtd/geoip2).

Do you plan to release this gem to rubygems and rename?

@da4nik
Copy link
Owner

da4nik commented Feb 7, 2014

I thought about this. Will do, I think.

@autarch
Copy link

autarch commented Feb 12, 2014

Just to chime in ...

First, thank you for creating this package. It's always nice to see folks out in the community supporting our products like this.

Ideally, you'd have two packages. One would be a low-level generic MaxMind DB interface that didn't care about the specific structure of records in the database. Then you could write a higher-level GeoIP2 specific interface on top of that.

We've done this for the APIs we maintain for Perl, Python, Java, and others. Those would be good examples for you to see where the separation is. See http://dev.maxmind.com/geoip/geoip2/downloadable/ for links to these APIs.

I'd also note that what we've done for the GeoIP2 packages is to provide a unified high-level interface to the web service and downloadable databases. You can create either a webservice client of a database reader, but they both return essentially the same objects when you look an IP up.

Thanks,

Dave Rolsky
Director of Software Engineering
MaxMind, Inc.
www.maxmind.com

@key88sf
Copy link
Author

key88sf commented Feb 12, 2014

@autarch Why doesn't MaxMind create an official Ruby gem for GeoIP2 ? Seems like you have SDKs for all the other major languages. I'm sure it would be very popular to have official support.

@autarch
Copy link

autarch commented Feb 12, 2014

@key88sf - We did a survey of our customers a while back to find out what languages they were using. Ruby didn't come in very high on that list, so we decided not to make an official API for it. I wouldn't rule out the possibility of doing so in the future if we had enough customer demand. But at least for now, our officially supported languages are PHP, Python, Perl, C, C#, Java, and an Apache module.

@key88sf
Copy link
Author

key88sf commented Feb 12, 2014

@autarch Hmm ok. I feel like if it's not done now, someone like @da4nik will create the gems eventually, so future Ruby customers would never end up requesting official gems from MaxMind. Might be good for you guys .... but when the format changes or something breaking like that happens, just sucks to wait so long for another Ruby library to come out. We use the original MaxMind GeoLite DB and are trying to migrate to version 2, so would be great to have something like this. Thanks!

@autarch
Copy link

autarch commented Feb 12, 2014

@key88sf - We won't be making breaking changes to the format. If we did we'd call it GeoIP3 or some more creative name ;)

I do agree that having official Ruby APIs would be nice, it's just a question of resources. It'd also be nice to have official Node, Rust, Go, Haskell, Clojure, etc. APIs too. Why can't we all agree to program in one language? Surely COBOL ought to have been good enough for everyone!

@mmzoo
Copy link

mmzoo commented Jan 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants