Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace jsonpb into protojson #16

Open
HurSungYun opened this issue Mar 24, 2022 · 0 comments
Open

replace jsonpb into protojson #16

HurSungYun opened this issue Mar 24, 2022 · 0 comments

Comments

@HurSungYun
Copy link
Contributor

HurSungYun commented Mar 24, 2022

Replacing jsonpb into protojson is needed because jsonpb has been deprecated.

Additionally, protojson allows us to use marshalOptions to use snake_case keys for marshalling. Only camelCase is supported currently in grpc access logs and it seems it's not a good practice.

protojson.MarshalOptions{
    UseProtoNames:   true,
    EmitUnpopulated: true,
},
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant