Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show custom image when loading? #46

Closed
wfjvdham opened this issue Feb 22, 2020 · 4 comments
Closed

Show custom image when loading? #46

wfjvdham opened this issue Feb 22, 2020 · 4 comments

Comments

@wfjvdham
Copy link

wfjvdham commented Feb 22, 2020

Would it not be a nice feature if users can pass their own image file to display when loading? Or is this implemented somewhere already?

@daattali
Copy link
Owner

daattali commented Mar 10, 2020

Looks like there's a package that extends this one https://github.com/emitanaka/shinycustomloader

@daattali
Copy link
Owner

daattali commented Jul 23, 2020

@wfjvdham I've implemented this in f884451

You can use withCustomSpinner() instead of withSpinner(). Please test and let me know if it works as expected.

@daattali
Copy link
Owner

daattali commented Jul 23, 2020

Update: instead of withCustomSpinner(), I changed it so that you still use withSpinner() with an image parameter

@wfjvdham
Copy link
Author

wfjvdham commented Jul 26, 2020

Nice! I like it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants