Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent pageSize in getAllCollection #12

Closed
JakeSidSmith opened this issue Nov 29, 2017 · 2 comments
Closed

Prevent pageSize in getAllCollection #12

JakeSidSmith opened this issue Nov 29, 2017 · 2 comments

Comments

@JakeSidSmith
Copy link
Contributor

[11:53 AM] Jake 'Sid' Smith: Currently you can pass a pageSize to getAllCollection.
[11:54 AM] Jake 'Sid' Smith: People have been incorrectly using this.

[11:54 AM] Jake 'Sid' Smith: You should set the type to:
[11:54 AM] Jake 'Sid' Smith:

pageSize?: never;
@JakeSidSmith
Copy link
Contributor Author

export interface NoPageSize {
  pageSize?: never;
}

function getAllCollectionAction (type: keyof T, opts?: CollectionOptions & NoPageSize, collectionName?: string) {

@AngryLawyer
Copy link
Contributor

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants