Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options are shared between instances #8

Closed
patric-eberle opened this issue May 5, 2022 · 1 comment
Closed

Options are shared between instances #8

patric-eberle opened this issue May 5, 2022 · 1 comment
Assignees
@pascalmoser
Labels
bug Something isn't working
Milestone
1.0.5

Comments

@patric-eberle
Copy link
Contributor

When creating a new FetchManager instance, it's options are shared between all forms on the page (later forms overwrite previous ones). This happens because Object.assign(target, ...sources) does not create a new object but extends the existing default value object.

js-pimcore-formbuilder/src/js/core/fetchManager.js

Line 11 in 0d142ab

this.options = Object.assign(FETCH_MANAGER_DEFAULTS, options);

Pull request: #7
@solverat solverat added the bug Something isn't working label Nov 16, 2022
@solverat solverat added this to the 1.0.5 milestone Nov 16, 2022
@solverat
Copy link
Member

Fixed via #7. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pascalmoser pascalmoser

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.5
Development

No branches or pull requests
3 participants
@solverat @pascalmoser @patric-eberle