Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve redirects when country code is not set in user languages #67

Closed
pascalmoser opened this issue Sep 14, 2020 · 1 comment
Closed
Assignees
Milestone

Comments

@pascalmoser
Copy link
Member

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no

I18n is ignoring a user locale without country code (de), when the same locale ist set in Pimcore with country code (de_CH).

Example 1:

User locales: de_CH, en
Pimcore locales: de, en

Current and expected Behavior: i18n redirects to de (working with PR #63)

Example 2:

User locales: de, en
Pimcore locales: de_CH, en

Current behavior: i18n redirects to en (ignoring de_CH)
Expected behavior: Redirect to de_CH because user preferred language should have more priority.

@pascalmoser pascalmoser self-assigned this Sep 14, 2020
@solverat solverat added this to the 3.2.5 milestone Nov 4, 2020
@solverat
Copy link
Member

solverat commented Nov 4, 2020

Fixed with #68.

@solverat solverat closed this as completed Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants