Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Func wrapper consistent with Lazy to use Resolve call for wrapped dependency #12

Closed
dadhi opened this issue Aug 31, 2018 · 2 comments
Closed

Make Func wrapper consistent with Lazy to use Resolve call for wrapped dependency #12

dadhi opened this issue Aug 31, 2018 · 2 comments
Assignees
@dadhi
Labels
enhancement New feature or request
Milestone
4.0.0

Comments

@dadhi
Copy link
Owner

dadhi commented Aug 31, 2018

Actually it is my fail to not include this change into v3.0.

The change is in internal but still may be breaking for someone. Comparing to the previous behavior, the change is more permissive (some nested dependencies allowed to be not registered yet) - so now it won't fail where previously it would.

But lets consider this a fix, bringing less surprizes to users. Then making it into 3.1 is fine :)
@dadhi dadhi changed the title Make Func wrapper consistent with Lazy to use Resolve call forvwrapped dependency Make Func wrapper consistent with Lazy to use Resolve call for wrapped dependency Aug 31, 2018
@dadhi
Copy link
Owner Author

dadhi commented Sep 5, 2018

Won't work at the moment cause require too many breaking changes.

@dadhi dadhi added this to the 4.0.0 milestone Sep 5, 2018
@dadhi dadhi added the enhancement New feature or request label Sep 5, 2018
@dadhi dadhi self-assigned this Feb 10, 2019
@dadhi
Copy link
Owner Author

dadhi commented Feb 10, 2019

Did not manage, not sure it is needed now.

@dadhi dadhi closed this as completed Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dadhi dadhi

Labels
enhancement New feature or request
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
1 participant
@dadhi