New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Websocket - attempt public url first #354

Closed

mingard opened this issue Oct 19, 2017 · 0 comments

Assignees

Labels

type: enhancement

Contributor

mingard commented Oct 19, 2017

Currently websocket attempts to use the current base url, with the server port.

Introduce publicUrl inline with other services
Use publicUrl.host and publicUrl.port by default for websocket
Fallback to server.host and server.port

mingard added the type: enhancement label

mingard self-assigned this

mingard mentioned this issue

fix: use publicUrl to determine websocket connection #356

Merged

mingard closed this as completed in #356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment