Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document save options drop-down: remember previously selected #379

Closed
abovedave opened this issue Jun 6, 2018 · 17 comments
Closed

Document save options drop-down: remember previously selected #379

abovedave opened this issue Jun 6, 2018 · 17 comments
Assignees
Milestone

Comments

@abovedave
Copy link
Contributor

screen shot 2018-06-06 at 14 33 14

Expected behavior

Per-user remember the previous state of this button - handy when bulk entering data.

Actual behavior

Always reverts to "save and continue"

@danwdart
Copy link
Contributor

danwdart commented Jul 5, 2018

Should this be stored upon the user in the database, or should it only be localStorage?

@abovedave
Copy link
Contributor Author

I think db so it persists across device and session?

@eduardoboucas
Copy link
Contributor

Worth noting that currently Publish doesn't store any metadata in API, so this is something that we need to consider and plan for carefully.

@danwdart
Copy link
Contributor

danwdart commented Jul 5, 2018

I think therefore that this is a synced PUT/GET to /${version}/${db}/users from the... redux store, maybe?

@eduardoboucas
Copy link
Contributor

And who creates that users collection?

@danwdart
Copy link
Contributor

danwdart commented Jul 5, 2018

The users would already be there, it's the same users as one logs in using, the auth?

@eduardoboucas
Copy link
Contributor

We're getting rid of that authentication method in favour of ACL, remember? ☺️

@danwdart
Copy link
Contributor

Of course, was a save place decided?

@eduardoboucas
Copy link
Contributor

Likely this: dadi/api#453. Until then, this one is blocked. 🚫

@danwdart
Copy link
Contributor

Okay - nice thanks

@eduardoboucas
Copy link
Contributor

⏳ Waiting for API 4.2.

@eduardoboucas
Copy link
Contributor

This can now be worked on, since API 4.2.0-rc4 (which the preview instance is running) includes support for arbitrary data against client records.

I propose a field for storing this preference, like publishSaveOptionsLastUsed (all fields should start with publish). This action allows you to save data against the client, so you should be able to use that.

If you have any questions, ping me on Slack.

@danwdart
Copy link
Contributor

Has the location for getting client data back out changed at all?

@eduardoboucas
Copy link
Contributor

Should all be here.

@danwdart
Copy link
Contributor

cool thanks

@danwdart danwdart assigned danwdart and unassigned danwdart Aug 17, 2018
@jimlambie jimlambie added this to the Week 36 milestone Aug 29, 2018
@danwdart danwdart self-assigned this Sep 19, 2018
@danwdart
Copy link
Contributor

@eduardoboucas this custom field, should it go under "data" in the user?

@danwdart
Copy link
Contributor

I figured it is "data" and made it work without any extra API changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants