Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Trailing useless bytes ignored while parsing PEM content #1563

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

dadrus
Copy link
Owner

@dadrus dadrus commented Jun 18, 2024

Related issue(s)

closes #1562

Checklist

  • I agree to follow this project's Code of Conduct.
  • I have read, and I am following this repository's Contributing Guidelines.
  • I have read the Security Policy.
  • I have referenced an issue describing the bug/feature request.
  • I have added tests that prove the correctness of my implementation.

Description

Fixes the referenced issue

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.58%. Comparing base (f8770b3) to head (17463ba).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1563   +/-   ##
=======================================
  Coverage   89.58%   89.58%           
=======================================
  Files         271      271           
  Lines        9084     9084           
=======================================
  Hits         8138     8138           
  Misses        702      702           
  Partials      244      244           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dadrus dadrus merged commit 8236eba into main Jun 18, 2024
27 checks passed
@dadrus dadrus deleted the fix/pem_parsing branch June 18, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heimdall freezes while loading of PEM files with trailing new lines
1 participant