Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve confirmation screen when closing add dialog #2282

Closed
dae opened this issue Dec 21, 2022 · 6 comments · Fixed by #2903
Closed

improve confirmation screen when closing add dialog #2282

dae opened this issue Dec 21, 2022 · 6 comments · Fixed by #2903

Comments

@dae
Copy link
Member

dae commented Dec 21, 2022

Yes/no buttons would be clearer as eg. "Discard" and "Keep Editing", and the prompt will probably need to be changed to something like "Discard current input?". This will probably require adding some new translation strings.

https://forums.ankiweb.net/t/saving-changes-to-evaluation-exit/25546

@chezfo
Copy link

chezfo commented Dec 21, 2022

It is important.

I also suggest turning the question around. Instead of "whether to throw away" the question should be "whether to keep". When the answer is "yes". Save and take you out of the editor. (and won't bring you back to save...)

https://forums.ankiweb.net/t/saving-changes-to-evaluation-exit/25546?u=noty

@dae
Copy link
Member Author

dae commented Dec 5, 2023

The user has issued a close action, so I think focusing on what will happen if they proceed (i.e. discard) makes more sense than talking about 'keep'ing.

When we tackle this, we might want to change the default button too: https://forums.ankiweb.net/t/close-and-lose-current-input-default-option-yes/38011

@chezfo
Copy link

chezfo commented Dec 5, 2023

You can make three options as in Word, and other software

  1. Save 2. Do not save 3. Cancel and return to editing.

@dae
Copy link
Member Author

dae commented Dec 6, 2023

Sorry, I don't really see the value in that. "Save" in this context means "Add", and I don't think users are typically going to add a card immediately after they've tried to close the window. Some way of saving a draft would be nice in the future, but that's a separate feature request.

@chezfo
Copy link

chezfo commented Dec 6, 2023

Now I realized the mistake...
There is no disagreement between us!
It's just that we're talking about two different dialog boxes...
Are you talking about an "add" dialog?
And I'm talking about a card template editing dialog box... 😃😃
Maybe you should open a new topic about it...

I'm talking about an evaluative exit. When editing an existing card template.
When you spend a lot of time editing, you don't always remember that the edit is not saved automatically and you have to click save.
This problem didn't start with Anki. It is found in every word processor, or graphics editor.
In all the programs I know, the program offers the option of saving or discarding, or returning to editing.

  • word and all office applications
  • PDF-XC
  • acrobat adobe
  • ABBYY FineReader
  • VScode

and many other programs. So I see no reason why Enki would behave differently.
Anyway from your response I understand that we are not talking about the same dialog box. That's why I'm attaching a picture.
תמונה

@dae
Copy link
Member Author

dae commented Dec 7, 2023

I'm sorry, I incorrectly assumed you were talking about the Add screen, and it looks like that screen already defaults to 'no'.

For the card types screen, I don't have strong feelings about a save button. The only argument against it I can think of is that it possibly conditions the user to hit esc when they want to save (which could result in lost work in other screens). But it's not a strong argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants