Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Spreadsheet Layer]: test spreadsheet #12

Open
jywarren opened this issue Jul 13, 2021 · 5 comments
Open

[New Spreadsheet Layer]: test spreadsheet #12

jywarren opened this issue Jul 13, 2021 · 5 comments

Comments

@jywarren
Copy link

New Spreadsheet Layer

Please describe the purpose of this layer

Layer Data

{"name":"Sites of interest","url":"https://docs.google.com/spreadsheets/d/1J9rqD-JfbGt5AdBYIpkeBZxetURSnIjlajkEX-aYvSk/edit?usp=sharing"}

Testing this out! Screenshots we could use in documentation:

Screen Shot 2021-07-13 at 10 40 45 AM

Screen Shot 2021-07-13 at 10 40 35 AM

Screen Shot 2021-07-13 at 10 41 09 AM

@jywarren
Copy link
Author

Hi @daemon1024 - just trying this out! Maybe we can also have a spreadsheet template people can copy, although it should be pretty easy right?

https://docs.google.com/spreadsheets/d/1J9rqD-JfbGt5AdBYIpkeBZxetURSnIjlajkEX-aYvSk/edit#gid=0

@daemon1024
Copy link
Owner

daemon1024 commented Jul 14, 2021

Added error handling, and the script will comment when action fails.
#16 ( Noting I made it fail intentionally )

Currently uses my account since it's my access token, can move on to a bot account later.

@daemon1024
Copy link
Owner

Things work fine now.
#19

Wondering why we have the dist file in gitignore since it's an important part of our repo I believe and that's what we are publishing essentially.

@daemon1024
Copy link
Owner

Maybe we can also have a spreadsheet template people can copy, although it should be pretty easy right?

Definitely, We can include it as part of documentation. I will note it down in the web page as well.

@jywarren
Copy link
Author

Wondering why we have the dist file in gitignore since it's an important part of our repo I believe and that's what we are publishing essentially.

I believe it's because we wanted to have it compiled only when we intend to - it makes it easier to merge PRs - and so we do it manually especially before releasing new versions on NPM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants