feat: support cmd command to reset to custom password #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wugeer
force-pushed
the
main
branch
4 times, most recently
from
ccebdd9
to
fb5a14f
Compare
mzz2017
reviewed
Mar 7, 2024
cmd/resetpass.go
Outdated
| }, | ||
| } | ||
| ) | ||
|
|
||
| func init() { | ||
| resetpassCmd.PersistentFlags().StringVarP(&cfgDir, "config", "c", filepath.Join("/etc", db.AppName), "config directory") | ||
| resetpassCmd.PersistentFlags().StringVarP(&userName, "name", "n", defaultUserName, "user name") |
There was a problem hiding this comment.
可以改成 username 和 -u 吗，这个比较 common sense
There was a problem hiding this comment.
可以改成 username 和 -u 吗，这个比较 common sense
好的，我修改下
There was a problem hiding this comment.
不建议给出默认值
username提供默认值主要是考虑到原先默认是改的是admin，想做这个兼容；不给默认值也可以的
cmd/resetpass.go
Outdated
| }, | ||
| } | ||
| ) | ||
|
|
||
| func init() { | ||
| resetpassCmd.PersistentFlags().StringVarP(&cfgDir, "config", "c", filepath.Join("/etc", db.AppName), "config directory") | ||
| resetpassCmd.PersistentFlags().StringVarP(&userName, "name", "n", defaultUserName, "user name") | ||
| resetpassCmd.PersistentFlags().StringVarP(&newUserPassword, "password", "P", defaultUserPassword, "user new password") |
|
Any updates on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
daeuniverse/daed#211 daed resetpass need to set custom password
Checklist
Full Changelogs
Issue Reference
Fix 211 daed resetpass need to set custom password
Test Result