Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"No trigger covering all quantified variables found" is still a warning with /warningsAsErrors #3358

Closed
mattmccutchen-amazon opened this issue Jan 12, 2023 · 0 comments · Fixed by #4430
Assignees
Labels
kind: bug Crashes, unsoundness, incorrect output, etc. If possible, add a `part:` label part: resolver Resolution and typechecking

Comments

@mattmccutchen-amazon
Copy link

Dafny version

master (f6bd1b8)

Code to produce this issue

datatype MyResult = Ok | Err(error: set<string>)
function method warningTriggerTest(sr: seq<MyResult>): set<string> {
  set i, err | 0 <= i < |sr| && err in (if sr[i].Err? then sr[i].error else {}) :: err
}

Command to run and resulting output

% ./dafny /compile:0 /warningsAsErrors warning-trigger.dfy
.../warning-trigger.dfy(3,2): Warning: /!\ No trigger covering all quantified variables found.

Dafny program verifier finished with 1 verified, 0 errors

What happened?

I'd expect /warningsAsErrors to convert the warning to an error, or else the documentation should explain why it doesn't.

What type of operating system are you experiencing the problem on?

Linux

@mattmccutchen-amazon mattmccutchen-amazon added the kind: bug Crashes, unsoundness, incorrect output, etc. If possible, add a `part:` label label Jan 12, 2023
@MikaelMayer MikaelMayer added the part: resolver Resolution and typechecking label Aug 17, 2023
@MikaelMayer MikaelMayer self-assigned this Aug 17, 2023
MikaelMayer added a commit that referenced this issue Aug 17, 2023
MikaelMayer added a commit that referenced this issue Aug 29, 2023
…-errors (#4430)

This PR fixes #3358
I also verified that there was no other places where we were missing to
convert warnings as errors by looking at all usages of
"ErrorLevel.Warning".
Tests added

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>

---------

Co-authored-by: Remy Willems <rwillems@amazon.com>
keyboardDrummer added a commit to keyboardDrummer/dafny that referenced this issue Sep 15, 2023
…-errors (dafny-lang#4430)

This PR fixes dafny-lang#3358
I also verified that there was no other places where we were missing to
convert warnings as errors by looking at all usages of
"ErrorLevel.Warning".
Tests added

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>

---------

Co-authored-by: Remy Willems <rwillems@amazon.com>
keyboardDrummer added a commit that referenced this issue Sep 19, 2023
…-errors (#4430)

This PR fixes #3358
I also verified that there was no other places where we were missing to
convert warnings as errors by looking at all usages of
"ErrorLevel.Warning".
Tests added

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>

---------

Co-authored-by: Remy Willems <rwillems@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Crashes, unsoundness, incorrect output, etc. If possible, add a `part:` label part: resolver Resolution and typechecking
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants