Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop updating v1 tag, encourage referencing specific version instead #9

Open
robin-aws opened this issue Nov 11, 2022 · 0 comments
Open

Comments

@robin-aws
Copy link
Member

The latest change (#8) broke the CI for https://github.com/dafny-lang/libraries because it was already installing the report generator itself, and dotnet tool install is not idempotent.

Ignoring for the moment whether this should have been considered a breaking change, it's really unfortunate for consumers to potentially break spontaneously when we publish a new version. I would strongly prefer to encourage users to reference a specific version (i.e. @v1.4.0 instead of @v1) and rely on dependabot to keep the version up to date instead: https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot

We will need to update the sample in the README accordingly, and warn about this change. Ideally we would remove the v1 tag entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant