[Bug] Missing sh script for Netlify universe package

[slumbering]

Dagger version : dagger 0.2.0-alpha.2

When using dagger init the Netlify universe package has a missing deploy.sh file which make the package unusable.

[grouville]

Reversing with @slumbering:

• It seems that we do not add the external scripts when vendoring universe.dagger.io. A dagger init copies the proper library, but without the imported scripts
• This also shows a weakness on our testing methodology: we test on the local packages only. We should also add tests using the vendored packages

[aluzzardi]

It seems that we do not add the external scripts when vendoring universe.dagger.io. A dagger init copies the proper library, but without the imported scripts

Indeed -- the problem lies in our go:embed statement which only includes .cue files:

dagger/pkg/pkg.go

Line 20 in 5d832a1

//go:embed */**/*.cue */**/**/*.cue

We should change this to include the entire directory.

This also shows a weakness on our testing methodology: we test on the local packages only. We should also add tests using the vendored packages

Yes. Vendoring is going to change dramatically with modules, so I don't think it's worth investing much time in this right now.

[slumbering]

@aluzzardi : should we have an array of authorized extension instead of include the entire directory ?

[aluzzardi]

@aluzzardi : should we have an array of authorized extension instead of include the entire directory ?

No we should include the entire directory. go:embed will be replaced by a git clone someday, and that's going to gather all files.