Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悶 Platform type is converted to string by the code generator #6466

Closed
sagikazarmark opened this issue Jan 19, 2024 · 3 comments 路 Fixed by #7158
Closed

馃悶 Platform type is converted to string by the code generator #6466

sagikazarmark opened this issue Jan 19, 2024 · 3 comments 路 Fixed by #7158

Comments

@sagikazarmark
Copy link
Contributor

What is the issue?

The core Platform type is converted to string when using a module that references that type.

Dagger version

dagger v0.9.6 (registry.dagger.io/engine) darwin/arm64

Steps to reproduce

No response

Log output

No response

Copy link
Contributor

Can you provide more details?

@sagikazarmark
Copy link
Contributor Author

I use Platform in this module.

When using that module as a dependency, the code generator turns Platform to string:

type GoWithSourceBuildOpts struct {
	// Target platform in "[os]/[platform]/[version]" format (e.g., "darwin/arm64/v7", "windows/amd64", "linux/arm64").
	//
	Platform string
}

@helderco
Copy link
Contributor

helderco commented Jan 23, 2024

So the issue must extend to all scalars then.

@sipsma, do we need a ScalarKind?

@helderco helderco added the kind/bug Something isn't working label Apr 20, 2024 — with Linear
@helderco helderco mentioned this issue Apr 30, 2024
7 tasks
@samalba samalba removed the kind/bug Something isn't working label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants