Fixes for File::chdir #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rms?) than abs_path. Some platforms implement abs_path via fast_abs_path which is a more dangerous function. getcwd doesn't seem to suffer that failing. I filed a bug on Cwd (https://rt.perl.org/rt3/Public/Bug/Display.html?id=115962) but this fix for File::chdir should work immediately. Addresses GitHub #3
…hen *Cwd::abs_path = \&Cwd::fast_abs_path
…d). README.pod will be rebuilt before release.
|
It is now my assessment that |
|
Thank you very much. Released to CPAN as 0.1008 |
|
Glad to help. It was a rather fun find actually! I took some pleasure in documenting it too :-) http://blogs.perl.org/users/joel_berger/2012/12/a-question-of-location.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These of course need to be tested on many platforms, but I believe from looking through the alias mapping in Cwd that Cwd::getcwd is going to be safer than Cwd::abs_path.