Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to disable environment variables UI organization-wide #16

Open
benpankow opened this issue Aug 21, 2023 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@benpankow
Copy link
Member

For organizations which have adopted other secret stores, having the option to set environment variables in the Dagster UI can be confusing and misleading. Organization admins could have the ability to disable the environment variable UI entirely so that it isn't used in place of the other secret store.

@benpankow benpankow added the enhancement New feature or request label Aug 21, 2023
@slopp
Copy link

slopp commented Aug 21, 2023

A similar "compliance" flavored request is to have the env var page act as "write once, read never". While it'd be possible to deploy code to print secrets, some security orgs just get really turned off by the ability to view the set secrets on that page

@azadabbasi
Copy link

There are a few reasons we are trying to stay away from the current behavior:

  • First and foremost we can't verify and control that users won't use Env variables as a secret store.
  • Even though envVars can be scoped to deployment groups/code locations, we find management and isolation of these env variables a bit difficult as there would be numerous users on the platform and each have access to multiple code locations and deployment groups.

It also makes sense to me if the OrgAdmins were the only ones allowed to see/set these Env Variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants