[dynamic] fix how skips cascade #11561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
alangenfeld
force-pushed
the
al/01-06-_dynamic_fix_how_skips_cascade
branch
from
4c17676
to
2fe9798
Compare
alangenfeld
force-pushed
the
al/01-06-_dynamic_fix_how_skips_cascade
branch
2 times, most recently
from
424f2b4
to
71ae514
Compare
sryza
approved these changes
Jan 6, 2023
| @@ -239,6 +245,8 @@ def get_next_step(self) -> ExecutionStep: | |||
| self.sleep_til_ready() | |||
| step = self.get_next_step() | |||
|
|
|||
| if step is None: | |||
| print("fuck") | |||
alangenfeld
force-pushed
the
al/01-06-_dynamic_fix_how_skips_cascade
branch
from
71ae514
to
81b9a7c
Compare
AlexanderVR
pushed a commit
to AlexanderVR/dagster
that referenced
this pull request
Jan 10, 2023
resolves dagster-io#10292 resolves dagster-io#5948 ### How I Tested These Changes added tests cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #10292
resolves #5948
How I Tested These Changes
added tests cases