[dagit] Add GraphQL configuration for VSCode #11565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
|
It would be nice if this didn't have to live in the root. Let me see if I can make that work... |
bengotow
approved these changes
Jan 6, 2023
Yeah, I can't figure out how to make it work. I think it has to live at the workspace root ( |
hellendag
force-pushed
the
dish/vscode-config
branch
from
38d0fe8
to
c05ce60
Compare
AlexanderVR
pushed a commit
to AlexanderVR/dagster
that referenced
this pull request
Jan 10, 2023
### Summary & Motivation Picking this back up from dagster-io#11500. Add a `.graphqlrc.yml` to the `dagster` root to allow the VSCode GraphQL language extension (https://marketplace.visualstudio.com/items?itemName=GraphQL.vscode-graphql) to find the `dagit` schema for autocompletion and validation. ### How I Tested These Changes Open `VersionNumber.tsx`, mess around with its query. <img width="568" alt="Screenshot 2023-01-06 at 4 17 04 PM" src="https://user-images.githubusercontent.com/2823852/211109434-50045504-3743-45cc-b917-898e9e95ea33.png"> <img width="336" alt="Screenshot 2023-01-06 at 4 17 16 PM" src="https://user-images.githubusercontent.com/2823852/211109438-fb196f66-b5bc-4739-89c1-029d6df8d26f.png"> <img width="614" alt="Screenshot 2023-01-06 at 4 18 17 PM" src="https://user-images.githubusercontent.com/2823852/211109440-ed90b399-d202-4abd-9e93-4a6bd73baefd.png">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Picking this back up from #11500.
Add a
.graphqlrc.ymlto thedagsterroot to allow the VSCode GraphQL language extension (https://marketplace.visualstudio.com/items?itemName=GraphQL.vscode-graphql) to find thedagitschema for autocompletion and validation.How I Tested These Changes
Open
VersionNumber.tsx, mess around with its query.