monitored_assets param for multi-asset sensor #11567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Maybe we should just shorten it to |
|
Or |
python_modules/dagster/dagster/_core/definitions/multi_asset_sensor_definition.py
Show resolved
Hide resolved
jamiedemaria
approved these changes
Jan 10, 2023
sryza
force-pushed
the
multi-asset-sensor-monitor-params
branch
from
e992954
to
e5a8497
Compare
sryza
force-pushed
the
multi-asset-sensor-monitor-params
branch
from
e5a8497
to
f86954c
Compare
sryza
force-pushed
the
multi-asset-sensor-monitor-params
branch
from
f86954c
to
fdabcde
Compare
sryza
changed the title
sryza
force-pushed
the
multi-asset-sensor-monitor-params
branch
from
fdabcde
to
a758a23
Compare
sryza
force-pushed
the
multi-asset-sensor-monitor-params
branch
from
a758a23
to
067ce52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This takes advantage of the fact that multi-asset sensor is a relatively recent experimental API to do a breaking change. It replaces the
asset_keysandasset_selectionarguments to@multi_asset_sensorwith a singlemonitored_assetsargument.The advantages:
asset_selectionparameter that acceptsUnion[AssetSelection, Sequence[AssetKey]], it would make life easier.asset_selectionparam on @sensor, which means something different.Fixes #11558.
How I Tested These Changes
bk