Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor unit testing docs section #1451

Closed
natekupp opened this issue Jun 7, 2019 · 2 comments
Closed

Refactor unit testing docs section #1451

natekupp opened this issue Jun 7, 2019 · 2 comments
Assignees
Labels
area: docs Related to documentation in general

Comments

@natekupp
Copy link
Contributor

natekupp commented Jun 7, 2019

This section needs work. There's a statement of "So let’s do that. Follow along in the comments:" that doesn't actually lead to any comments. Also, this section isn't written similarly to real-world unit test code. I feel like it would be better to demonstrate this with something like @pytest.mark.parametrize to show a more useful test case.

@natekupp natekupp added the area: docs Related to documentation in general label Jun 7, 2019
@natekupp natekupp self-assigned this Jun 7, 2019
@schrockn schrockn assigned schrockn and unassigned natekupp Jun 7, 2019
@schrockn
Copy link
Member

schrockn commented Jun 7, 2019

I'm working on testing so I can do this

@mgasner
Copy link
Contributor

mgasner commented Dec 16, 2019

These docs have been rewritten since this issue was opened.

@mgasner mgasner closed this as completed Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general
Projects
None yet
Development

No branches or pull requests

3 participants