Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pydantic 2 #15162

Closed
jamiedemaria opened this issue Jul 7, 2023 · 8 comments
Closed

Add support for pydantic 2 #15162

jamiedemaria opened this issue Jul 7, 2023 · 8 comments
Assignees

Comments

@jamiedemaria
Copy link
Contributor

What's the use case?

update the resources and config system to support pydantic 2

Ideas of implementation

No response

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 馃憤! We factor engagement into prioritization.

@lainiwa
Copy link

lainiwa commented Jul 25, 2023

Pydantic v2 also contains v1 functionality, so likely Dagster could be updated to be v2-compatible just by editing imports: pydantic v2 docs.

@mjclarke94
Copy link

Is there any update on this? @lainiwa 's suggestion might be a nice intermediate approach whilst resources/config are updated to make use of the new features.

We have an interfaces library which is decoupled from dagster, but aren't able to bump that to pydantic 2 whilst some environments need both dagster and our interfaces tool.

@zaneselvans
Copy link

There's also the helpful little utility https://github.com/pydantic/bump-pydantic which can make many of the changes required to migrate from v1 to v2 automatically.

@emanueledomingo
Copy link

Hi guys, do you have an ETA for this?

@benpankow
Copy link
Member

Hi all, just wanted to let you know that this is is something we're actively taking a look at - it's a bit too early to provide an ETA, but we will keep you updated as this proceeds. Since we rely on some of Pydantic's internals, it means we unfortunately can't rely solely on the compatibility layer.

@aeturrell
Copy link

I've run into this as an issue, great to know it's under active consideration.

@ttamg
Copy link

ttamg commented Sep 25, 2023

Any update on this move to pydantic v2 please?

@benpankow
Copy link
Member

The relevant compat layer will be shipping with Dagster 1.5.5 on October 26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants