Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repin sphinxcontrib-images to trunk #1858

Closed
mgasner opened this issue Oct 21, 2019 · 3 comments
Closed

Repin sphinxcontrib-images to trunk #1858

mgasner opened this issue Oct 21, 2019 · 3 comments
Labels
area: docs Related to documentation in general dependencies

Comments

@mgasner
Copy link
Contributor

mgasner commented Oct 21, 2019

Depends on spinus/sphinxcontrib-images#55
@mgasner mgasner added the area: docs Related to documentation in general label Oct 21, 2019
@mgasner
Copy link
Contributor Author

mgasner commented Oct 22, 2019 •
edited

there's going to be an issue with dev-requirements too, because sphinx >= 2 is py3 only

@mgasner mgasner changed the title Upgrade to Sphinx >2.0 Repin sphinxcontrib-images to trunk Nov 5, 2019
@mgasner
Copy link
Contributor Author

mgasner commented Nov 5, 2019

Right now we are using git+https://github.com/t-b/sphinxcontrib-images.git@c76b9c25efb249f9c5054adbb436455095c6d2f7#egg=sphinxcontrib-images to pull in the fix on spinus/sphinxcontrib-images#56 -- we would like to get back to PyPI once this merges

@mgasner
Copy link
Contributor Author

mgasner commented Apr 13, 2020

https://dagster.phacility.com/D2538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: docs Related to documentation in general dependencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mgasner