Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP waiting on already updated parent #20177

Closed
mjkanji opened this issue Mar 1, 2024 · 5 comments
Closed

AMP waiting on already updated parent #20177

mjkanji opened this issue Mar 1, 2024 · 5 comments
Labels
area: auto-materialize Related to Auto Materialization type: bug Something isn't working

Comments

@mjkanji
Copy link

mjkanji commented Mar 1, 2024

Dagster version

version 1.5.14

What's the issue?

I am orchestrating my DBT project using the following AMP:

class DailyDagsterDbtTranslator(CustomDagsterDbtTranslator):
    def get_auto_materialize_policy(
        self, dbt_resource_props: Mapping[str, Any]
    ) -> AutoMaterializePolicy:
        return AutoMaterializePolicy.lazy().with_rules(
            AutoMaterializeRule.skip_on_not_all_parents_updated(),
            AutoMaterializeRule.materialize_on_cron(cron_schedule="0 1 * * *"),
        )

Most of my DBT DAG is behaving correctly, but I noticed that one branch has not orchestrated correctly since February 28. See the following:

image

chargify_customer_summary is an external asset made using external_assets_from_specs and is materialized daily using a job that does context.log_event(AssetMaterialization(asset_key=...)).

This job is correctly logging materialization events for chargify_customer_summary. However, its children are not materializing and the Automation page shows they are waiting for chargify_customer_summary to be updated.

See the Automation page for one of its children (customer_sub_history):

customer_sub_history_automation

Note the times. chargify_customer_summary was materialized at 5 AM (see the DAG screenshot above) but at 6 AM, customer_sub_history says it's still waiting for the parent to be updated.

Looking at the events for customer_sub_history shows successful materializations every day until February 28th:

customer_sub_history_events

Based on those dates, I'm wondering if this is somehow a leap-year bug?

What did you expect to happen?

That customer_sub_history would successfully materialize daily.

How to reproduce?

No response

Deployment type

Dagster Cloud

Deployment details

Dagster Cloud Serverless.

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

@mjkanji mjkanji added the type: bug Something isn't working label Mar 1, 2024
@garethbrickman garethbrickman added the area: auto-materialize Related to Auto Materialization label Mar 1, 2024
@cbini
Copy link
Contributor

cbini commented Mar 1, 2024

Just noticed this myself. Looks like the last time it worked was around 5 PM ET on 2/28.

@OwenKephart
Copy link
Contributor

Hi @mjkanji thanks for the report. We've identified the issue here and a fix has been rolled out to Dagster Cloud.

For OSS users, the same fix will be available in next week's 1.6.9 release, or reverting to 1.6.6 will also avoid this issue.

@mjkanji
Copy link
Author

mjkanji commented Mar 3, 2024

Hi @OwenKephart, could you please clarify how the fix takes effect? I'm on Dagster Cloud Serverless and even after running my DBT DAG manually earlier in the day (to refresh the 'state' of all the assets), the assets downstream of my external assets are still not triggering at their AMP cron tick. The Automation page continues to say they're waiting for their (external asset) parents, which have already been updated.

Is the fix applied automatically for Cloud users or do I need to upgrade to the 1.6.9 release? I am on version 1.5.14 for your reference.

@OwenKephart
Copy link
Contributor

Hi @mjkanji apologies for the confusion here -- there was a secondary fix that needed to happen on the cloud end to fully solve this issue, which has now been rolled out (as of this morning). No action is required on your end if you are a cloud user.

@mjkanji
Copy link
Author

mjkanji commented Mar 6, 2024

Hi @mjkanji apologies for the confusion here -- there was a secondary fix that needed to happen on the cloud end to fully solve this issue, which has now been rolled out (as of this morning). No action is required on your end if you are a cloud user.

Awesome, thanks! I was also able to confirm that my DAGs are running as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: auto-materialize Related to Auto Materialization type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants