Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dagster/max_runtime tag does not seem to work #21813

Closed
cwe5590 opened this issue May 13, 2024 · 2 comments
Closed

dagster/max_runtime tag does not seem to work #21813

cwe5590 opened this issue May 13, 2024 · 2 comments
Labels
area: deployment Related to deploying Dagster type: bug Something isn't working

Comments

@cwe5590
Copy link

cwe5590 commented May 13, 2024

Dagster version

dagster, version 1.7.5

What's the issue?

I am not able to get the max_runtime feature to work properly in my production deploy in k8s nor with a contrived example (see below). I'm not sure this still works, but I'm likely missing something obvious.

@op
def my_op():
    time.sleep(30)

@job(tags={"dagster/max_runtime": 10})
def my_job():
    my_op()

https://docs.dagster.io/deployment/run-monitoring#general-run-timeouts

What did you expect to happen?

I would expect the above contrived example to fail due to timeout

How to reproduce?

No response

Deployment type

None

Deployment details

No response

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

@cwe5590 cwe5590 added the type: bug Something isn't working label May 13, 2024
@garethbrickman
Copy link
Contributor

garethbrickman commented May 13, 2024

Did you enable run_monitoring in your dagster.yaml file?

# Opt in to run monitoring
run_monitoring:
  enabled: true

@cwe5590
Copy link
Author

cwe5590 commented May 13, 2024

I have not enabled that so that explains it. Thanks @garethbrickman

@cwe5590 cwe5590 closed this as completed May 13, 2024
@garethbrickman garethbrickman added the area: deployment Related to deploying Dagster label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: deployment Related to deploying Dagster type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants