Hooks: slack_on_success and slack_on_failure fail silently to work #22052
Labels
area: integrations
Related to general integrations, including requests for a new integration
type: bug
Something isn't working
Dagster version
1.7.6 and older 1.5.13
What's the issue?
Wanted to use dagster_slack.slack_on_success and dagster_slack.slack_on_failure hooks.
Implemented them as in:
https://docs.dagster.io/_apidocs/libraries/dagster-slack#dagster_slack.slack_on_success
And they just plainly DID not work.
While I had a working slack - dagster integration I knew that was not the issue.
Finally I changed 1 line on both of hook's functions:
Changed from:
context.resources.slack.chat_postMessage(channel=channel, text=text)
To:
context.resources.slack.get_client().chat_postMessage(channel=channel, text=text)
And the hooks started working properly
What did you expect to happen?
The hooks to work
How to reproduce?
Create hooks according to:
https://docs.dagster.io/_apidocs/libraries/dagster-slack#dagster_slack.slack_on_success
Deployment type
None
Deployment details
No response
Additional information
No response
Message from the maintainers
Impacted by this issue? Give it a 👍! We factor engagement into prioritization.
The text was updated successfully, but these errors were encountered: