Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks: slack_on_success and slack_on_failure fail silently to work #22052

Open
tgardela opened this issue May 23, 2024 · 0 comments
Open

Hooks: slack_on_success and slack_on_failure fail silently to work #22052

tgardela opened this issue May 23, 2024 · 0 comments
Labels
area: integrations Related to general integrations, including requests for a new integration type: bug Something isn't working

Comments

@tgardela
Copy link

Dagster version

1.7.6 and older 1.5.13

What's the issue?

Wanted to use dagster_slack.slack_on_success and dagster_slack.slack_on_failure hooks.
Implemented them as in:
https://docs.dagster.io/_apidocs/libraries/dagster-slack#dagster_slack.slack_on_success
And they just plainly DID not work.
While I had a working slack - dagster integration I knew that was not the issue.
Finally I changed 1 line on both of hook's functions:
Changed from:
context.resources.slack.chat_postMessage(channel=channel, text=text)
To:
context.resources.slack.get_client().chat_postMessage(channel=channel, text=text)
And the hooks started working properly

What did you expect to happen?

The hooks to work

How to reproduce?

Create hooks according to:
https://docs.dagster.io/_apidocs/libraries/dagster-slack#dagster_slack.slack_on_success

Deployment type

None

Deployment details

No response

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

@tgardela tgardela added the type: bug Something isn't working label May 23, 2024
@garethbrickman garethbrickman added the area: integrations Related to general integrations, including requests for a new integration label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: integrations Related to general integrations, including requests for a new integration type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants