Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Comma after surname included in catalog greeting #22728

Open
kristianandre opened this issue Jun 26, 2024 · 0 comments
Open

[UI] Comma after surname included in catalog greeting #22728

kristianandre opened this issue Jun 26, 2024 · 0 comments
Labels
area: UI/UX Related to User Interface and User Experience Dagster+ Relates to Dagster paid plans type: bug Something isn't working

Comments

@kristianandre
Copy link

Dagster version

1.7.10

What's the issue?

At my company we have all our names in Entra ID start with the surname followed by the first name. So "Kristian André Jakobsen" is written as "Jakobsen, Kristian André". While it is a very minor issue, the asset catalog page renders the greeting as "Good afternoon, Jakobsen," including the comma at the end.

image

What did you expect to happen?

I am not sure if it makes sense to remove stop signs in the name when rendering the greeting, but it might make it look a bit cleaner. One could also include the full name.

How to reproduce?

No response

Deployment type

Dagster Cloud

Deployment details

No response

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

@kristianandre kristianandre added the type: bug Something isn't working label Jun 26, 2024
@garethbrickman garethbrickman added area: UI/UX Related to User Interface and User Experience Dagster+ Relates to Dagster paid plans labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UI/UX Related to User Interface and User Experience Dagster+ Relates to Dagster paid plans type: bug Something isn't working
Projects
Status: Tracking internally
Development

No branches or pull requests

2 participants