Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When outputs are tied to assets, include OutputDefinition metadata in AssetMaterialization #3894

Closed
sryza opened this issue Mar 18, 2021 · 1 comment

Comments

@sryza
Copy link
Contributor

sryza commented Mar 18, 2021

Use Case

Users are currently responsible for passing through output metadata to their asset materializations. It would be convenient if the yield EventMetadataEntry below was not required.

class MyIOManager(IOManager):
    def handle_output(self, context, value):
        ...
        yield EventMetadataEntry.text(context.metadata["path"], label="path")

    def get_output_asset_key(self, context):
        ...

@solid(output_defs=OutputDefinition(metadata={"path": "/a/b/c"}))
def my_solid():
    ...

Ideas of Implementation

This would require some sort of schematization of output metadata so that it's displayable in Dagit.

Additional Info


Message from the maintainers:

Excited about this feature? Give it a 👍. We factor engagement into prioritization.

@yuhan yuhan added this to Untriaged in Practitioner via automation Apr 13, 2021
@yuhan yuhan moved this from Untriaged to Not High Priority in Practitioner Apr 13, 2021
@sryza
Copy link
Contributor Author

sryza commented Apr 20, 2023

With SDAs and associated metadata, we no longer need this

@sryza sryza closed this as completed Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants