Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set format based on extension #151

Merged
merged 1 commit into from
Jun 23, 2015
Merged

Conversation

urg
Copy link
Contributor

@urg urg commented Jul 19, 2013

There appears to be a bug where if you set the output file with extension and give an input file, the output file will be generated only as a pdf. This is a quick fix to get it working, but don't know the script very well, so perhaps there's a better place to add this fix.

@dagwieers dagwieers force-pushed the master branch 3 times, most recently from 3a5dc40 to bf7097d Compare April 23, 2015 09:55
@skywinder
Copy link
Contributor

Nice addition! @dagwieers I think, it makes sense to merge it. Thoughts?

@dagwieers
Copy link
Member

Looks fine, however I would use.lstrip('.') instead. And maybe document the surrounding code as well ;-) I will amend the change after merging.

Thanks !

dagwieers added a commit that referenced this pull request Jun 23, 2015
@dagwieers dagwieers merged commit fd4f3a1 into unoconv:master Jun 23, 2015
@dagwieers
Copy link
Member

Done. 291895b

@skywinder
Copy link
Contributor

@dagwieers is back! Hooray! 👍

@dagwieers
Copy link
Member

@skywinder I was flooded by lots of unoconv PR closings, so you did get my attention ;-)

PS I wouldn't mind if you want to get more involved and merge PRs or do releases.

@ghost
Copy link

ghost commented Oct 26, 2017

This is a late comment, but this broke my system. I recently upgraded my server to the next Ubuntu LTS and with it came the new Unoconv.

My system makes a tempfile with a random name and without extension, then called the unoconv binary and supplied the path to the --output parameter. Then my system went looking for this file, which wasn't there because it was looking for /tmp/tempfile_TQC4Nd and unoconv wrote to /tmp/tempfile_TQC4Nd.csv.

I worked around this by doing the following:
(unoconv -vvvvvvvvvvvvvvvv --format csv --stdout infile.xls > /tmp/tempfile_TQC4Nd) 2>&1

I'm using a subshell here so I can redirect the stderr messages to the stdout without it ending up in the converted file (and log the debug messages).

For the record, this is not a complaint (Unoconv has made my life so much easier when dealing with awful Office file formats), I just wanted to say that sometimes changes that seem low impact can indeed break other peoples systems. And if there is someone else who ran into this problem, they can use my solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants