Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterized subdag #110

Merged
merged 4 commits into from
Mar 16, 2023
Merged

Parameterized subdag #110

merged 4 commits into from
Mar 16, 2023

Conversation

elijahbenizzy
Copy link
Collaborator

[Short description explaining the high-level reason for the pull request]

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@elijahbenizzy elijahbenizzy force-pushed the parameterized-subdag branch 6 times, most recently from 9ec374e to b116211 Compare March 14, 2023 23:42
@elijahbenizzy
Introduces parameterized-subdag
f7fe4ad 
This does exactly what parameterized does, but for subdags. Baically
provides a way to create multiple subdags with one. Recommended for
power users, but can prove valuable.
@elijahbenizzy elijahbenizzy marked this pull request as ready for review March 15, 2023 00:00
@elijahbenizzy elijahbenizzy mentioned this pull request Mar 15, 2023
Closed
3 tasks
@elijahbenizzy
Fixes default arguments for subdags
aee9a8b 
There was a bug in the code in which no inputs or config would get a null-pointer
exception. This fixes it!
@elijahbenizzy elijahbenizzy merged commit d283218 into main Mar 16, 2023
@elijahbenizzy elijahbenizzy deleted the parameterized-subdag branch March 16, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrawcz skrawcz skrawcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elijahbenizzy @skrawcz