Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added fwf reader #838

Merged
merged 2 commits into from
Apr 30, 2024
Merged

added fwf reader #838

merged 2 commits into from
Apr 30, 2024

Conversation

swapdewalkar
Copy link
Contributor

Address #837

Changes

Changed in pandas extension files

How I tested this

unit tests

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@skrawcz
Copy link
Collaborator

skrawcz commented Apr 24, 2024

looks good, just pre-commit failure to fix please!

@skrawcz skrawcz merged commit 149e541 into DAGWorks-Inc:main Apr 30, 2024
23 checks passed
@skrawcz
Copy link
Collaborator

skrawcz commented Apr 30, 2024

Thanks @swapdewalkar I realized I could easily update the pre-commit fix myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants