-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET Core Port #2
Comments
I'm mostly there with the project updates I just posted. I now just need to figure out how to build both the .NET Standard assembly and the multiple .NET Framework assemblies at the same time. All the files and project are updated and I just have the .NET Standard build line commented out. |
@dahall Just add |
Done, and it works. You have to add it after the .NET Framework builds or VS has a problem. I just checked in those changes. I will do some testing and tweaks to make sure the disabled features fail gracefully and then release a NuGet package with the support. |
oh, Awesome! Thanks for that. Interesting about the order, I did have an issue where the restore didn't work. |
Just a status update: I am waiting to push the code until I can adequately test it in a UWP or console app. I can't do that until MS releases VS 2017 15.4. So, as soon as that update comes out, I will test and then release a NuGet with netstandard2.0 included. |
I figured out a way to test ahead of VS15.4 and have run into a big problem. .NET Standard 2.0 does not support COM IEnumerable. This interfaces is used extensively by Microsoft in the base library. I'm looking for work arounds, but, so far, have come up empty. This may need to be put on hold until MS added COM support to .NET Standard. Thoughts? |
Which part of the code has those IEnumerables? |
The native COM objects IActionCollection, ITriggerCollection, IRegisteredTaskCollection and IRunningTaskCollection are all native COM interfaces that support a special COM version of IEnumerable. The .NET interop code that handles working with COM doesn't implement that special IEnumerable so it can't convert it to the .NET version. |
Same issue w/ the IEnums. I'll be looking at possible solutions also as I'd like to migrate a project to .NET core. Has there been any word from Microsoft as to whether they'll be adding COM support to .NET Standard? |
Microsoft has not even hinted as of today on what will be a part of the next .NET Standard release. |
It looks like they don't intend to support However, I think I have found a work around. It works for the |
Wow. Thanks for this workaround. How comfortable are you that the changes in your PR do not change any of the API (breaking change)? I'd be glad to just pull them straightway, but don't want to break anyone's existing code. |
Added to release 2.7.2! Thanks for your help. |
@dahall No worries. I didn't test all the methods, just the enumerating the tasks. I did just realise that I incorrectly Thanks, I'll try it out! |
We use your library, so thank you for making it available and maintaining it. We are looking at moving to .NET Core, and I'm wondering what your plans are for making a .NET Core version available as well.
I've attempted a port of the
TaskService
projects, and the only bit I found that wasn't supported is theWindowsImpersonationContext
and theEventLog
stuff.The text was updated successfully, but these errors were encountered: