-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Canada #25
Comments
please comment if you are in canada and willing to verify the implementation there |
I'm in Canada an have a vehicle registered with uvo. I have python experience as well so I'm more than willing to chip in where I can. |
@speedking456 that's very exciting, I'll start on a API wrapper for CA today and should have something for you to try in a day or two from the pypi package |
@speedking456 I think the wrapper is ready, can you run it in the python console to improve the wrapper's documentation?
from a python console run
but with real username, password, and PIN. the console should show all the responses raw json; if you can post the responses I'll add them to the API files for reference like I did for the us kia version https://github.com/dahlb/kia_uvo/blob/master/kia_uvo_api/src/kia_uvo_api/us_kia.py#L139 BE SURE TO REMOVE ANY PII like vin, but I'm not sure which PII will be in the responses, you could email it to me at dahl.brendan@gmail.com if you want a second pair of eyes to check for PII before it's online. Feel free to add the documentation in a PR if you'd like :). I'll start working on the HA side of changes for CA but that'll take a few days and be much better with the responses for reference. |
I think I've gotten the bulk of it working for Canada in the integration; it's in master. The service calls are still in F instead of C but I'm hoping to work that out tomorrow. I haven't been able to test it but short of typos I'm pretty confident it'll work, please let me know your experience. Having those responses documented for the API is still important and will help with the vehicle attributes like model name and debugging. PS: I'm new to python myself, only been doing it the last month or so for this project. If you notice any best practices or other issues, please let me know and I'll work on improving it. |
No description provided.
The text was updated successfully, but these errors were encountered: