Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ruby/rb/rt tags to div #1

Merged
merged 2 commits into from Dec 18, 2019
Merged

Replace ruby/rb/rt tags to div #1

merged 2 commits into from Dec 18, 2019

Commits on Dec 18, 2019

  1. Replace ruby/rb/rt tags to div

    Firefox enforce height of rb and rt, and it can not patch by
    `!important` flag. To fix wrong render between each browsers, I
    can not use ruby tag and use div commonly. I considered also
    `display: ruby`, but Firefox only supports that and others
    does not. This commit(and PR) make header same at each browsers.
    item4 committed Dec 18, 2019
    Copy the full SHA
    7339007 View commit details
    Browse the repository at this point in the history
  2. Keep symantic and display both

    1. Rollback contents in `<h1>`. It will keep symantic.
    2. Add new JavaScript codes to replace contents in `<h1>` to
       pritty display markup.
    item4 committed Dec 18, 2019
    Copy the full SHA
    2f002d7 View commit details
    Browse the repository at this point in the history