Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toml serialization mismatch #17

Closed
glguy opened this issue Jan 17, 2024 · 1 comment
Closed

Toml serialization mismatch #17

glguy opened this issue Jan 17, 2024 · 1 comment
Assignees
@dahlia
Labels
bug Something isn't working

Comments

@glguy
Copy link

glguy commented Jan 17, 2024

Hi,

I was taking a look to see how people were using toml-parser. I noticed that your ToTable and FromValue instances for Kernel don't match. One uses release and the other version.

dojang/src/Dojang/Syntax/Env.hs

Line 69 in d5e8049

<*> (fromString <$> reqKey "version")

@dahlia
Copy link
Owner

dahlia commented Jan 18, 2024

Thanks for your reporting! I'm going to quickly fix it.

@dahlia dahlia self-assigned this Jan 18, 2024
@dahlia dahlia added the bug Something isn't working label Jan 18, 2024
@dahlia dahlia closed this as completed in 2d702a4 Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dahlia dahlia

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glguy @dahlia