Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog example cannot be built because KV connection is listening indefinitely #39

Closed
marvinhagemeister opened this issue Apr 16, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@marvinhagemeister
Copy link

Building the blog example is broken because the process is kept open indefinitely so the build task never finishes. Reason for that is that a Deno KV instance is opened and a listener is attached eagerly. This will prevent the process from exiting.

The kv queue is eagerly listened through this call here:

this.#kv.listenQueue(handler);
which is ultimately kicked off eagerly in the constructor of the Federation class here: https://github.com/dahlia/fedify/blob/main/federation/middleware.ts#L197

Commenting this out makes the build task finish as expected.

Steps to reproduce

  1. Go into the examples blog folder: cd examples/blog
  2. Run deno task build -> Process never exists
@dahlia dahlia self-assigned this Apr 16, 2024
@dahlia dahlia added the bug Something isn't working label Apr 16, 2024
@dahlia dahlia closed this as completed in f4021c2 Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants