Fix encoder of messagepack to keep in pool

daichirata · Dec 15, 2017 · 2620523 · 2620523
1 parent d0cdf96
commit 2620523
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/logger.go b/logger.go
@@ -6,8 +6,6 @@ import (
 	"strings"
 	"sync"
 	"time"
-
-	"gopkg.in/vmihailenco/msgpack.v2"
 )
 
 var (
@@ -65,8 +63,7 @@ func (logger *Logger) PostWithTime(tag string, t time.Time, obj interface{}) err
 	}
 
 	m := getMessage()
-	enc := msgpack.NewEncoder(m.buf)
+	if err := m.enc.Encode(record); err != nil {
-	if err := enc.Encode(record); err != nil {
 		return err
 	}
 	logger.buf.Add(m)

diff --git a/message.go b/message.go
@@ -3,10 +3,13 @@ package fluent
 import (
 	"bytes"
 	"sync"
+
+	"gopkg.in/vmihailenco/msgpack.v2"
 )
 
 type Message struct {
 	buf *bytes.Buffer
+	enc *msgpack.Encoder
 }
 
 var messagePool = sync.Pool{
@@ -26,7 +29,9 @@ func putMessage(message *Message) {
 }
 
 func newMessage() *Message {
+	buf := bytes.NewBuffer([]byte{})
 	return &Message{
-		buf: bytes.NewBuffer([]byte{}),
+		buf: buf,
+		enc: msgpack.NewEncoder(buf),
 	}
 }