-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 BUG: Weekly/Daily email updates #1224
Comments
Hi @rnboo, Thanks for the report. We will look into that |
Hey @idoshamun , I looked into the codeBase and found a fix. I'm new to contributing in open-source projects , so pls take a look at the change and comment for changes , happy to do it |
Hi @BharathSubu! Thank you for your interest in fixing the issue. If you want to submit a PR, you will have to:
The steps above should help you to raise your first PR here in our repo. I would love it if you could follow through the steps so people can see that you were the one who actually fixed the issue and gain the |
Hey @sshanzel I have made the PR |
@BharathSubu thank you so much for fixing the issue! 鉂わ笍 馃コ 馃嵒 |
What went wrong? 馃
When having the 'Weekly' option selected for setting personalized emails once a week and then setting a time to send the mail, the option is automatically set to 'Daily'. This can be byc confirmed by reloading the page/closing the app and going back to the notification settings, the time is correctly set, while option 'Daily' is selected.
Edit: I was able to recreate the same behaivior when changing the settings as mentioned on desktop
Expected Behavior
It seems that the weekly option cant be configured together with the time setting under the 'Email Notifications' settings
Steps to Reproduce Issue
Solution Proposed
No response
Screenshots
![DESCRIPTION](LINK.png)
Environment
No response
Browsers
No response
OS
No response
Version of daily.dev
No response
Additional Context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: