Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 BUG: Weekly/Daily email updates #1224

Closed
1 task done
rnboo opened this issue Jun 18, 2024 · 5 comments
Closed
1 task done

馃悰 BUG: Weekly/Daily email updates #1224

rnboo opened this issue Jun 18, 2024 · 5 comments

Comments

@rnboo
Copy link

rnboo commented Jun 18, 2024

What went wrong? 馃

When having the 'Weekly' option selected for setting personalized emails once a week and then setting a time to send the mail, the option is automatically set to 'Daily'. This can be byc confirmed by reloading the page/closing the app and going back to the notification settings, the time is correctly set, while option 'Daily' is selected.

Edit: I was able to recreate the same behaivior when changing the settings as mentioned on desktop

Expected Behavior

It seems that the weekly option cant be configured together with the time setting under the 'Email Notifications' settings

Steps to Reproduce Issue

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See the error

Solution Proposed

No response

Screenshots

![DESCRIPTION](LINK.png)

Environment

No response

Browsers

No response

OS

No response

Version of daily.dev

No response

Additional Context

No response

Code of Conduct

  • I follow the conditions of this project.
@idoshamun
Copy link
Member

Hi @rnboo,

Thanks for the report. We will look into that

@BharathSubu
Copy link

BharathSubu commented Jun 26, 2024

Hey @idoshamun , I looked into the codeBase and found a fix. I'm new to contributing in open-source projects , so pls take a look at the change and comment for changes , happy to do it

WhatsApp Image 2024-06-26 at 5 18 25 PM

@sshanzel
Copy link
Member

sshanzel commented Jun 28, 2024

Hi @BharathSubu! Thank you for your interest in fixing the issue. If you want to submit a PR, you will have to:

  1. Fork the project: https://github.com/dailydotdev/apps/fork
  2. Make a branch for the fix.
  3. Make changes on that branch (can easily be done through our GitPod setup).
  4. Raise the PR.

The steps above should help you to raise your first PR here in our repo. I would love it if you could follow through the steps so people can see that you were the one who actually fixed the issue and gain the Contributor badge 鉂わ笍

@BharathSubu
Copy link

Hey @sshanzel I have made the PR

@sshanzel
Copy link
Member

@BharathSubu thank you so much for fixing the issue! 鉂わ笍 馃コ 馃嵒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants