Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve the display of repositories pr url at the end #307

Conversation

JordanGoasdoue
Copy link
Collaborator

@JordanGoasdoue JordanGoasdoue commented Jan 30, 2024

I've put it as a feature because it changes the behavior of octopilot

Let's take as example a repository where the PR is unrevised (the PR already exist, not yet merged and doesn't need new update)

INFO[0001] Updates finished                              repositories-count=1
INFO[0001] Update summary (Unrevised)                    unrevised-repository-count=1
INFO[0001] Update summary (Unrevised)                    unrevised-repository-pr-url="https://github.com/xxx/yyy/pull/777"

Let's take as example a repository where the PR is created / updated by octopilot

INFO[0001] Updates finished                            repositories-count=1
INFO[0001] Update summary (Updated)                    updated-repository-count=1
INFO[0001] Update summary (Updated)                    updated-repository-pr-url="https://github.com/xxx/yyy/pull/888"

For instance in dry-run you will be able to see already opened PR that doesn't need new changes compare to the one you want to apply.

WARN[0173] Running in dry-run mode, not pushing changes  repository=a/z

INFO[0173] Updates finished                              repositories-count=5
INFO[0173] Update summary (Unrevised)                    unrevised-repository-count=3
INFO[0173] Update summary (Unrevised)                    unrevised-repository-pr-url="https://github.com/a/b/pull/5"
INFO[0173] Update summary (Unrevised)                    unrevised-repository-pr-url="https://github.com/a/c/pull/41"
INFO[0173] Update summary (Unrevised)                    unrevised-repository-pr-url="https://github.com/a/d/pull/7"

It's also easier this way to list all the pullrequests and order them by type (unrevised vs updated)

@JordanGoasdoue JordanGoasdoue requested review from vbehar and a team as code owners January 30, 2024 15:31
@JordanGoasdoue JordanGoasdoue merged commit a8be14e into dailymotion-oss:master Mar 29, 2024
8 of 9 checks passed
@JordanGoasdoue JordanGoasdoue deleted the refactor-display-repositories-pr-url branch March 29, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants