refactor: refactoring introducing a single generic strategy #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the Strategy interface and its dedicated implementations for a generic strategy to pool logic and reduce code duplication.
Adds the Repository field to switchBranchOptions for reuse in switchBranch and ease access to repository information such as full name.
Forwards the Repository struct to commitChanges to ease access to repository information such as full name.
Updates the signature of the commiChanges function to take an approach using an opts parameter with a dedicated commitOptions struct to be consistent with the signatures of other similar functions.
Adds the Repository field to pushOptions for reuse in pushChanges and ease access to repository information such as full name.
Adds the implementation of a CommitMessage struct dedicated to handling commit messages with the separation between the headline and the body.
Moves the creation of the commit message directly into the pull request strategy and forward it into commit options.
Replaces the ForcePush and ForceBranchCreation strategy options with ResetFromBase to make the strategy implementation more readable.
Maximilien-R
force-pushed
the
refactor/strategies
branch
from
c36a440
to
6608c1e
Compare
JordanGoasdoue
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to refactor the implementation of the strategies to move from an interface with an implementation dedicated to each strategy to a generic strategy whose behaviour is defined according to its options.
This refactoring should reduces the code duplication and ease maintenance and the addition of new feature.
Note: I tried to create unit commits to make it easier to review pull request commit by commit.