Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make LocalTransform be update packed #19

Closed
dakom opened this issue Mar 3, 2020 · 2 comments
Closed

make LocalTransform be update packed #19

dakom opened this issue Mar 3, 2020 · 2 comments

Comments

@dakom
Copy link
Owner

dakom commented Mar 3, 2020

Would allow setting it without going through TRSO

@dakom
Copy link
Owner Author

dakom commented Dec 23, 2020

To make it always push the values in the other direction and therefore keep everything in sync, it needs to:

  1. Decompose the TRSO values and set those components as well
  2. Clear those (but not other TRSO's) from their update packs

For the sake of consistent math across math libraries, the decomposition should be a function on the Matrix4 impl.

A naive first-step could be without step 2, i.e. just set the values and then let it re-propogate to the LocalTransform. This is probably more expensive than clearing the update pack list, but likely not a huge difference.

@dakom dakom changed the title maybe LocalTransform be update packed too... make LocalTransform be update packed Dec 23, 2020
@dakom
Copy link
Owner Author

dakom commented Dec 23, 2020

LocalTransform itself is now update-packed... doesn't push changes backwards though, that'll be a separate issue

@dakom dakom closed this as completed Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant