Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a run command #31

Closed
daleal opened this issue Oct 26, 2020 · 0 comments · Fixed by #34
Closed

Create a run command #31

daleal opened this issue Oct 26, 2020 · 0 comments · Fixed by #34
Labels
feature New feature or request proposal For new ideas not being considered at that moment

Comments

@daleal
Copy link
Owner

daleal commented Oct 26, 2020

Given that most of the potential users of asymmetric are people who don't want to have to write a ton of code/learn multiple things to get their APIs running, maybe it would be a good idea to transform uvicorn into a dependency of asymmetric and provide a CLI command for running the API directly from asymmetric (something like asymmetric run module). Another option would be to conditionally import uvicorn with a try/except piece of code, provide the run CLI option and fail if uvicorn isn't installed. That could be a nice compromise (not requiring uvicorn if you're going to use another ASGI server to serve your API, but having the command in case someone wants to just plug and play, given that they also install uvicorn to be able to run it). The last option would be simply not to include a run command, and writing good documentation about ways to start the API that are very friendly to people new to the API development world.

@daleal daleal added feature New feature or request proposal For new ideas not being considered at that moment labels Oct 26, 2020
@daleal daleal linked a pull request Oct 27, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request proposal For new ideas not being considered at that moment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant