Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-architect zum #2

Merged
merged 5 commits into from Mar 20, 2021
Merged

Re-architect zum #2

merged 5 commits into from Mar 20, 2021

Conversation

daleal
Copy link
Owner

@daleal daleal commented Mar 20, 2021

Chore: Re-architect zum

Description

This Pull Request re-writes almost the whole codebase to be a bit more flexible. This is by no means a clean version of the library yet, but it is now quite a bit more structured compared to how it was written before.

Requirements

None.

Additional changes

Some classes were renamed (for example, Executor is now called Engine). Now the engine saves a state that can be retrieved, instead of directly printing the output to the console.

@daleal daleal added chore For chores in the repo design For design decisions refactor Move stuff around labels Mar 20, 2021
@daleal daleal self-assigned this Mar 20, 2021
@codecov-io
Copy link

codecov-io commented Mar 20, 2021

Codecov Report

Merging #2 (62fa4de) into master (52c5dcd) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master      #2   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           8      11    +3     
  Lines         102     131   +29     
======================================
- Misses        102     131   +29     
Impacted Files Coverage Δ
zum/cli.py 0.00% <0.00%> (ø)
zum/configs/core.py 0.00% <0.00%> (ø)
zum/configs/errors.py 0.00% <0.00%> (ø)
zum/constants.py 0.00% <0.00%> (ø)
zum/engine.py 0.00% <0.00%> (ø)
zum/executor.py 0.00% <0.00%> (ø)
zum/requests/core.py 0.00% <0.00%> (ø)
zum/requests/errors.py 0.00% <0.00%> (ø)
zum/requests/models.py 0.00% <0.00%> (ø)
zum/requests/validations.py 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52c5dcd...62fa4de. Read the comment docs.

@daleal daleal merged commit 0f356be into master Mar 20, 2021
@daleal daleal deleted the chore/re-architect-zum branch March 20, 2021 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore For chores in the repo design For design decisions refactor Move stuff around
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants