Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rand_core to 0.6 #64

Merged
merged 2 commits into from Sep 15, 2021

Conversation

PaulGrandperrin
Copy link
Contributor

https://github.com/rust-random/rand/blob/master/rand_core/CHANGELOG.md
This new version makes using rand_core on wasm seamless (thanks to the update of getrandom to v0.2)
The crate compiles well with this PR, but since some rand_core traits are publicly exposed in this crate's API, this is strictly speaking a breaking change.

https://github.com/rust-random/rand/blob/master/rand_core/CHANGELOG.md
This new version makes using rand_core on wasm seamless (thanks to the update of getrandom to v0.2)
The crate compiles well with this PR, but since some rand_core traits are publicly exposed in this crate's API, this is strictly speaking a breaking change.
@PaulGrandperrin
Copy link
Contributor Author

it'll be very useful for a crate like https://github.com/novifinancial/opaque-ke to be used in a browser

@Frederick888
Copy link

Sorry if I overlooked something, but is

use rand_core::OsRng;
actually needed? I updated rand_core locally without enabling getrandom and removed this line, then tried e.g. cargo test --features=default,serde,std,u64_backend and it seemed ok.

PaulGrandperrin added a commit to PaulGrandperrin/x25519-dalek that referenced this pull request Dec 22, 2020
Which allows to not use the "getrandom" feature of the rand_core
create.
Thanks to Frederick Zhang (@Frederick888) for the suggestion:
dalek-cryptography#64 (comment)
@PaulGrandperrin
Copy link
Contributor Author

@Frederick888 I pushed a new commit removing the use of OsRng and the getrandom feature, but for some reason, it didn't trigger a new travis test.

@Andrew-Shay
Copy link

Any status updates on this PR?

@PaulGrandperrin
Copy link
Contributor Author

It seems that there is an issue with the leadership and release process at https://github.com/dalek-cryptography.
See dalek-cryptography/curve25519-dalek#338 (comment)
Maybe @hdevalence will create x25519-dalek-ng with new PR merged?

@isislovecruft
Copy link
Member

isislovecruft commented Mar 25, 2021

Hey, I'm happy to merge this into a 2.x alpha which tracks the curve25519-dalek 4.x alphas, if that is a tenable solution to fix problems in production deploys which want the latest rand. I don't have a hard date set yet for releasing those new major versions, as I would like to minimise future backporting efforts, but also maximise downstream compatibility and batch enough breaking changes together to not be a continual breakage point. Thoughts, anyone?

@mcginty
Copy link
Contributor

mcginty commented May 12, 2021

Both snow and innernet would benefit from an alpha, since you can't cargo publish crates with git dependencies, for what it's worth :).

@isislovecruft isislovecruft changed the base branch from main to release/2.0 September 15, 2021 00:04
Copy link
Member

@isislovecruft isislovecruft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isislovecruft isislovecruft merged commit e870a3d into dalek-cryptography:release/2.0 Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants