make sure localDateValue() takes local daylight savings into account #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalelotts
added a commit
that referenced
this pull request
Oct 21, 2016
…ys if there is a daylight savin Now it uses the timezoneOffset of the specific day to calculate the localDateValue Closes #345
|
Thanks for the PR! Nice catch! I think this have been around for a while but nobody picked up on it. I'm doing to close this PR and submit as a change to the develop branch - note that I changed your implementation to eliminate the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
call to localDateValue() returns the wrong value for some days if there is a daylight saving change in this month as it only looks at the timezoneOffset for today instead of the actual day
What is the new behavior (if this is a feature change)?
it uses the timezoneOffset of the specific day to calculate the localDateValue
Does this PR introduce a breaking change?
no
Please check if the PR fulfills these requirements
Other information: