Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReferenceError in DlDateTimePickerComponent._handleKeyDown #426

Merged
merged 1 commit into from
Apr 4, 2018

Conversation

steven-hadfield
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix

What is the current behavior? (You can also link to an open issue here)
On key press, a Javascript ReferenceError is triggered due to an undefined variable

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

Other information:
Targeting master as develop is very out of date

Fix 'ReferenceError: event is not defined' in _handleKeyDown caused by not using '$event' parameter
@dalelotts dalelotts merged commit 22dd5c7 into dalelotts:master Apr 4, 2018
@dalelotts
Copy link
Owner

Thanks for the PR! Sorry about making such a silly* mistake.

I'll bring develop up-to-date right now.

  • Silly was not my first choice =)

@steven-hadfield
Copy link
Contributor Author

Thanks for the quick turnaround. No worries about the mistake, we all make them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants